-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Widevine VMP on MacOS and Windows #2023
Conversation
e595a9b
to
2e1ce10
Compare
9bd374d
to
ef65c7a
Compare
ef65c7a
to
0214901
Compare
86421d1
to
4dc1ca1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, need a rebase
bbf2819
to
52a897b
Compare
@darkdh Rebased on master |
I'll not merge this now because this PR makes conflict with C74 and C74 will be merged soon. |
VMP is enabled with official build and all below envs are set. SIGN_WIDEVINE_KEY: private key SIGN_WIDEVINE_CERT: widevine cert SIGN_WIDEVINE_PASSPHRASE: pass for key sig generator should be located in //third_party/widevine/scripts/signature_generator.py
browser signing is removed from `create_dist` target. Instead, build` step will do signing and generate widevine sig file. Then, those signed files and sig files will be used during the `create-dist`. This is because gn python can't use external cryptgraphy module needed by sig generator scripts. So, brave-browser `build` target will use system python for it.
52a897b
to
e1d9144
Compare
@darkdh Would you approve again? I rebased this PR on C74. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious why this is failing patching, when CI runs. It uses brave-browser
branch enable_cdm_host_verification
, which is properly rebased and has the correct Chromium 74 pinned: brave/brave-browser@65f03ec
Whoops - RE: the above, it needs brave/brave-browser#3903 (which isn't in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, pending CI passing
VMP is enabled with official build and all below envs are set.
SIGN_WIDEVINE_KEY: private key
SIGN_WIDEVINE_CERT: widevine cert
SIGN_WIDEVINE_PASSPHRASE: pass for key
sig generator should be located in
//third_party/widevine/scripts/signature_generator.py before build starts on buildbot.
Issue brave/brave-browser#944
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests
) onnpm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Check sig file is in installed folder.
On MacOS, sig file(
Brave Browser Framework.sig
) is inBrave Browser.app/Contents/Versions/7x.x.x.x/Widevine Resources.bundle/Contents/Resources/Brave Browser Framework.sig
On Windows, sig files(
brave.exe.sig
,chrome.dll.sig
andchrome_child.dll.sig
) are inC:\Program Files (x86)\BraveSoftware\Brave-Browser-XXX\Application\7x.x.x.x\
Check netflix works
Reviewer Checklist: