Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] - Fix #34752: Add Variations Support #21283

Merged
merged 1 commit into from
Dec 8, 2023
Merged

[iOS] - Fix #34752: Add Variations Support #21283

merged 1 commit into from
Dec 8, 2023

Conversation

Brandon-T
Copy link
Contributor

  • Adds Variations Support in iOS by enabling it via the config

Resolves brave/brave-browser#34752

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@Brandon-T Brandon-T added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 labels Dec 7, 2023
@Brandon-T Brandon-T added this to the 1.63.x - Nightly milestone Dec 7, 2023
@Brandon-T Brandon-T self-assigned this Dec 7, 2023
@Brandon-T Brandon-T requested review from a team and bridiver as code owners December 7, 2023 01:38
@Brandon-T Brandon-T enabled auto-merge (squash) December 7, 2023 01:40
@Brandon-T Brandon-T merged commit 1e3a2cf into master Dec 8, 2023
20 checks passed
@Brandon-T Brandon-T deleted the bugfix/iOS-Variations branch December 8, 2023 00:18
tmancey pushed a commit that referenced this pull request Jan 29, 2024
@Brandon-T @tmancey
[iOS] - Fix #34752: Add Variations Support (#21283)
0dbcac3 
- Add Variations Support for iOS
@tmancey tmancey mentioned this pull request Jan 29, 2024
Merged
4 tasks
kjozwiak pushed a commit that referenced this pull request Jan 31, 2024
@tmancey @Brandon-T
iOS griffin support - 1.62.x (#21803)
aca169c 
* [iOS] - Fix #34752: Add Variations Support (#21283)

- Add Variations Support for iOS

* Fix #35593: Remove browser policy connector override for iOS (#21758)

- Remove browser policy connector override on iOS. 
- Desktop doesn't have it, and having it null will prevent variations and other services from working.

---------

Co-authored-by: Brandon-T <bthomas@brave.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylehickinson kylehickinson kylehickinson approved these changes

@bridiver bridiver bridiver approved these changes

Assignees

@Brandon-T Brandon-T

Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Milestone
1.63.x - Release
Development

Successfully merging this pull request may close these issues.

[iOS] - Add Variations Support
3 participants
@Brandon-T @bridiver @kylehickinson