Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storybook - better determine correct brave-core output path allowing specification via param or fallback to most recently built (uplift to 1.64.x) #22734

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Storybook - better determine correct brave-core output path allowing specification via param or fallback to most recently built (uplift to 1.64.x) #22734

merged 1 commit into from
Mar 22, 2024
+86 −37

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Mar 22, 2024 •
edited by kjozwiak
Loading

Uplift of #21443
Resolves brave/brave-browser#34984

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner March 22, 2024 17:55
@brave-builds brave-builds added this to the 1.64.x - Release #2 milestone Mar 22, 2024
@brave-builds brave-builds self-assigned this Mar 22, 2024
@github-actions github-actions bot added the CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) label Mar 22, 2024
kjozwiak
kjozwiak approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.64.x approved 👍

@kjozwiak kjozwiak merged commit 93acb3e into 1.64.x Mar 22, 2024
15 checks passed
@kjozwiak kjozwiak deleted the pr21443_storybook-target-param_1.64.x branch March 22, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps)
Projects
None yet
Milestone
1.64.x - Release #2
Development

Successfully merging this pull request may close these issues.
2 participants
@brave-builds @kjozwiak