Remove remote resource requests from newtab webui #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bridiver
approved these changes
Jul 6, 2018
fmarier
pushed a commit
that referenced
this pull request
Oct 29, 2019
Update scripts for create_dist
fmarier
pushed a commit
that referenced
this pull request
Oct 29, 2019
* Set build target through the config for create_dist * check config.gClientVerbose directly * change lib/util methood buildMuon to buildCore
fmarier
pushed a commit
that referenced
this pull request
Oct 29, 2019
Was supposed to be fixed in #229 but lost a few commits. We fix the snakecasing done by commander.js there but don't set the ref correctly because the name differs from what is set by lib/config.js. This adds a parameter to the projects config to specify what should be used for the command line arg (defaults to name.replace('-', '_'). Fixes #299
petemill
pushed a commit
that referenced
this pull request
Jul 27, 2020
Update scripts for create_dist
petemill
pushed a commit
that referenced
this pull request
Jul 27, 2020
* Set build target through the config for create_dist * check config.gClientVerbose directly * change lib/util methood buildMuon to buildCore
petemill
pushed a commit
that referenced
this pull request
Jul 27, 2020
Was supposed to be fixed in #229 but lost a few commits. We fix the snakecasing done by commander.js there but don't set the ref correctly because the name differs from what is set by lib/config.js. This adds a parameter to the projects config to specify what should be used for the command line arg (defaults to name.replace('-', '_'). Fixes #299
petemill
pushed a commit
that referenced
this pull request
Jul 28, 2020
Update scripts for create_dist
petemill
pushed a commit
that referenced
this pull request
Jul 28, 2020
* Set build target through the config for create_dist * check config.gClientVerbose directly * change lib/util methood buildMuon to buildCore
petemill
pushed a commit
that referenced
this pull request
Jul 28, 2020
Was supposed to be fixed in #229 but lost a few commits. We fix the snakecasing done by commander.js there but don't set the ref correctly because the name differs from what is set by lib/config.js. This adds a parameter to the projects config to specify what should be used for the command line arg (defaults to name.replace('-', '_'). Fixes #299
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix brave/brave-browser#501
Fix brave/brave-browser#273
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist: