-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-land zcash keyring support #23383
Conversation
/build ios |
* Add Orchard support to Zcash keyring Resolves brave/brave-browser#32303 * Review fix * Review fix * Review fix * Review fix * Switch enable_orchard buildflag * Review fix * encapsulate rust code inside wrappers so we don't expose cxx types * Build fix * Build&Review fix --------- Co-authored-by: bridiver <34129+bridiver@users.noreply.github.com>
[puLL-Merge] - brave/brave-core@23383 Here is my review of the pull request: DescriptionThis PR adds support for Orchard key generation and address derivation in the Brave Wallet. The main motivation seems to be expanding Brave Wallet's ZCash capabilities to enable shielded transactions through the Orchard protocol. ChangesChanges
Security Hotspots
Overall, this is a significant change that introduces a complex new ZCash protocol to the wallet. The implementation should undergo thorough security testing and auditing, especially the core cryptographic components. Users' privacy and funds security depends on the robustness of the Orchard integration. |
This is a re-land disabled by default and @brave/crypto-wallets-core already approved the original PR so force merging |
Resolves brave/brave-browser#32303
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: