-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android component updater #2484
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to review code only. I'm not very familiar with the logic. So better to have an another reviewer as well.
base::Bind(base::IgnoreResult( | ||
&OnBeforeURLRequestDispatchOnIOThread), next_callback, ctx)); | ||
// TODO(bridiver) - fix this | ||
OnBeforeURLRequestAdBlockTP(ctx); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you elaborate on what you want to fix here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually the comment can just be removed, I had that there as a reminder from before our conversation
976fa95
to
396a587
Compare
fb77ddd
to
4d5a958
Compare
4d5a958
to
886dc91
Compare
} | ||
|
||
void TrackingProtectionService::UpdateFirstPartyStorageTrackers( | ||
std::vector<std::string>) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
std::vector<std::string> storage_trackers
if (storage_trackers_buffer_.empty()) { | ||
LOG(ERROR) << "Could not obtain tracking protection data"; | ||
void TrackingProtectionService::OnGetSTPDATFileData(std::string contents) { | ||
DCHECK_CURRENTLY_ON(BrowserThread::IO); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove, since this is on main thread now.
@@ -30,6 +30,10 @@ namespace brave_shields { | |||
// checking and init. | |||
class AdBlockBaseService : public BaseBraveShieldsService { | |||
public: | |||
using GetDATFileDataResult = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we also have template< typename T > using GetDATFileDataResult = std::pair<std::unique_ptr<T>, brave_component_updater::DATFileDataBuffer>
in components/brave_component_updater/browser/dat_file_util.h
?
also apply to AutoplayWhitelistService
, ExtensionWhitelistService
and TrackingProtectionService
he resolved them, not sure why this is still saying he requested changes
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security
) onnpm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.