Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 128.0.6613.114 to Chromium 128.0.6613.120 #25405

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Sep 2, 2024

Resolves brave/brave-browser#40804

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mkarolin mkarolin added CI/run-network-audit Run network-audit CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) labels Sep 2, 2024
@mkarolin mkarolin self-assigned this Sep 2, 2024
@mkarolin mkarolin requested review from a team as code owners September 2, 2024 18:27
@kjozwiak kjozwiak requested a review from a team September 3, 2024 02:19
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 As per @diracdeltas, the noplatform failure due to the deps issue doesn't block.

@kjozwiak kjozwiak merged commit 4cf37d7 into master Sep 3, 2024
17 of 18 checks passed
@kjozwiak kjozwiak deleted the 128.0.6613.120_master branch September 3, 2024 02:21
@github-actions github-actions bot added this to the 1.71.x - Nightly milestone Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade from Chromium 128.0.6613.114 to Chromium 128.0.6613.120
3 participants