Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(wallet): Use Nala Alert for Wallet Banners #25667

Merged

Conversation

Douglashdaniel
Copy link
Contributor

Description

Updates the Wallet Banners to now use the Nala Alert component

Resolves brave/brave-browser#41036

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Create a new Profile and Wallet, but do not backup your Wallet yet.
  2. Go to the Portfolio page and test the Backup Wallet alert, make sure all buttons work.
  3. Go to brave://settings/web3 and set your default wallet to Extensions (no fallback).
  4. Go back to the Portfolio page and test the Default Wallet alert, make sure all buttons work.

Desktop View

Light Mode:

image image image

Dark Mode:

image image image

Panel View

Light Mode:

image image image

Dark Mode:

image image image

@Douglashdaniel Douglashdaniel self-assigned this Sep 20, 2024
@Douglashdaniel Douglashdaniel requested a review from a team as a code owner September 20, 2024 00:06
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet labels Sep 20, 2024
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@Douglashdaniel Douglashdaniel force-pushed the style-wallet-use-nala-alert-for-wallet-banners branch from 206f089 to 462d257 Compare September 20, 2024 01:15
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@Douglashdaniel Douglashdaniel force-pushed the style-wallet-use-nala-alert-for-wallet-banners branch from 462d257 to b65c189 Compare September 20, 2024 14:57
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@Douglashdaniel Douglashdaniel merged commit 6bf0b59 into master Sep 20, 2024
17 checks passed
@Douglashdaniel Douglashdaniel deleted the style-wallet-use-nala-alert-for-wallet-banners branch September 20, 2024 16:06
@github-actions github-actions bot added this to the 1.72.x - Nightly milestone Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Wallet Banners to use Nala Alert Component
3 participants