Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): BTC and ZEC Buy Quotes from Route #26419

Merged

Conversation

Douglashdaniel
Copy link
Contributor

Description

Fixes a bug where Buy quotes were not being fetched for BTC and ZEC when clicking buy from the Portfolio page.

Resolves brave/brave-browser#42083

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Open the Wallet and navigate to the Portfolio screen
  2. Open the more menu for BTC or ZEC and click Buy
  3. After being routed to the Buy screen Buy Quotes should be fetch.

Before:

Screen.Recording.3.mov

After:

Screen.Recording.2.mov

@Douglashdaniel Douglashdaniel self-assigned this Nov 6, 2024
@Douglashdaniel Douglashdaniel requested a review from a team as a code owner November 6, 2024 22:04
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet labels Nov 6, 2024
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@Douglashdaniel Douglashdaniel force-pushed the fix-wallet-btc-and-zec-buy-quotes-from-route branch from b248b2b to 83451fb Compare November 7, 2024 01:48
@Douglashdaniel Douglashdaniel merged commit e6eceb0 into master Nov 8, 2024
17 checks passed
@Douglashdaniel Douglashdaniel deleted the fix-wallet-btc-and-zec-buy-quotes-from-route branch November 8, 2024 14:53
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Nov 8, 2024
@brave-builds
Copy link
Collaborator

Released in v1.75.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Providers for BTC/ZCash only show up when trying to select token from list and not from Portfolio
3 participants