Fetch staged entries from Brave Search before opt-in to Leo #26424
+8
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… no entries - This avoid us falling into the situation where users need to click on summarize the page to continue the opt-in flow when user first open Leo from Brave Search. - There are still no requests will be sent to AI chat server unless user opts in. This only allows the request to fetch from Brave Search backend.
github-actions
bot
added
the
CI/storybook-url
diracdeltas
reviewed
Nov 7, 2024
diracdeltas
reviewed
Nov 7, 2024
| @@ -1047,8 +1047,7 @@ void ConversationHandler::MaybeFetchOrClearContentStagedConversation() { | |||
| } | |||
|
|
|||
| const bool can_check_for_staged_conversation = | |||
| ai_chat_service_->HasUserOptedIn() && IsContentAssociationPossible() && | |||
| should_send_page_contents_; | |||
| IsContentAssociationPossible() && should_send_page_contents_; | |||
There was a problem hiding this comment.
are the staged entries just the local chat history? so nothing is fetched from any servers to get the staged conversation.
There was a problem hiding this comment.
Staged entries are fetched from Brave Search server.
There was a problem hiding this comment.
@yrliou that's the only case in which they are fetched from a server?
There was a problem hiding this comment.
Currently, yes, our only source of staged entries is Brave Search server.
yrliou
changed the title
diracdeltas
approved these changes
Nov 7, 2024
|
A Storybook has been deployed to preview UI for the latest push |
ShivanKaul
approved these changes
Nov 7, 2024
petemill
approved these changes
Nov 7, 2024
|
Released in v1.75.4 |
|
Verification passed on
26424.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open via continue with Leo button from Brave Search:
Screen.Recording.2024-11-06.at.12.32.27.PM.mov
Open Leo manually:
Screen.Recording.2024-11-06.at.12.59.59.PM.mov
Note that this changes requirement 1.6 in https://docs.google.com/document/d/1idelFPpUEcKDNcyKYf3M5yw91tuIddjrlYfpaWEJjNk/edit?tab=t.0, tagging @diracdeltas and @ShivanKaul here to make sure it's okay from security and privacy perspective. Will update the spec once this change is approved.
Edit: above has been updated to reflect the change in this PR.
Resolves brave/brave-browser#42112
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: