-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wallet): ZCash Text Memo #26442
Merged
Merged
+227
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
CI/storybook-url
Deploy storybook and provide a unique URL for each build
feature/web3/wallet
feature/web3/wallet/core
labels
Nov 7, 2024
mkarolin
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
strings
++
A Storybook has been deployed to preview UI for the latest push |
onyb
reviewed
Nov 8, 2024
onyb
reviewed
Nov 8, 2024
components/brave_wallet_ui/page/screens/send/send_screen/send_screen.tsx
Outdated
Show resolved
Hide resolved
onyb
reviewed
Nov 8, 2024
components/brave_wallet_ui/components/extension/confirm-transaction-panel/transaction-info.tsx
Outdated
Show resolved
Hide resolved
onyb
reviewed
Nov 8, 2024
...t_ui/components/desktop/popup-modals/transaction_details_modal/transaction_details_modal.tsx
Outdated
Show resolved
Hide resolved
onyb
approved these changes
Nov 8, 2024
Douglashdaniel
force-pushed
the
feat-wallet-zcash-text-memo
branch
from
November 8, 2024 15:48
63ec49f
to
dbf9b81
Compare
cypt4
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
components/brave_wallet_ui/page/screens/send/constants/magics.ts
Outdated
Show resolved
Hide resolved
Douglashdaniel
force-pushed
the
feat-wallet-zcash-text-memo
branch
from
November 8, 2024 17:58
dbf9b81
to
568cacd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI/storybook-url
Deploy storybook and provide a unique URL for each build
feature/web3/wallet/core
feature/web3/wallet
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a
Memo
field on theSend
screen forZCash
Shielded transactions.Resolves brave/brave-browser#41986
Resolves brave/brave-browser#42078
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
ZCash Shielded Transactions
is enabledWallet
and navigate to theSend
tabZCash
as theToken
to send.Unified Shielded
address to send toAdd memo
button, click itMessage
and create the transactionMemo
is displayed in theConfirm Transaction
panelMemo
is displayed in theActivity
tab.Screen.Recording.6.mov