Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet): ZCash Text Memo #26442

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Conversation

Douglashdaniel
Copy link
Contributor

Description

Adds a Memo field on the Send screen for ZCash Shielded transactions.

Resolves brave/brave-browser#41986
Resolves brave/brave-browser#42078

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Make sure that ZCash Shielded Transactions is enabled
  2. Open the Wallet and navigate to the Send tab
  3. Select ZCash as the Token to send.
  4. Paste in a ZCash Unified Shielded address to send to
  5. You should now see a Add memo button, click it
  6. Enter a memo Message and create the transaction
  7. Check that the Memo is displayed in the Confirm Transaction panel
  8. Check that the Memo is displayed in the Activity tab.
Screen.Recording.6.mov

@Douglashdaniel Douglashdaniel self-assigned this Nov 7, 2024
@Douglashdaniel Douglashdaniel requested review from a team as code owners November 7, 2024 19:26
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet feature/web3/wallet/core labels Nov 7, 2024
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strings++

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Collaborator

@cypt4 cypt4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@Douglashdaniel Douglashdaniel merged commit e07362f into master Nov 8, 2024
17 checks passed
@Douglashdaniel Douglashdaniel deleted the feat-wallet-zcash-text-memo branch November 8, 2024 21:00
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet/core feature/web3/wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Memo field to Confirm Transaction Panel Add ZCash Text Memo Field on Send Screen
5 participants