Enable help webui for checking update status and upgrade detector #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonhong
changed the title
7 tasks
simonhong
force-pushed
the
cleanup_sparkle_glue
branch
from
2d11761
to
046533b
Compare
|
+1 on deleting the update button, can be pretty confusing with silent updates enabled now |
simonhong
force-pushed
the
cleanup_sparkle_glue
branch
5 times, most recently
from
e5c7419
to
2f7f5c5
Compare
* Delete update item from menu * Delete BraveAppController. Initialize sparkle in BraveBrowserMainPartsMac instead. * Move SUUpdateDelegate impl to SparkleGlueMac
simonhong
force-pushed
the
cleanup_sparkle_glue
branch
from
2f7f5c5
to
83f7255
Compare
|
Rebased on C68. |
This PR disables sparkle's dialog UI.
With this, browser notifies that install is ready via app menu button.
simonhong
changed the title
|
With this, all mac update related issues are cleared. |
|
Kindly ping.. |
bbondy
approved these changes
Jul 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close brave/brave-browser#316
SparkleGlue is glue layer between VersionUpdater/UpgradeDectector and Sparkle framework.
VersionUpdater is used to check update status and trigger update by about page.
UpgradeDetector is periodically checks whether there is already installed new version. If it detects newly installed one, notify it to its observers(app menu button). Then, observers notify/warn to relaunch browser.
This PR
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Manual update test.
Upgrade detector test by
/src/out/Debug/Brave.app/Contents/MacOS/Brave --enable-logging=stderr --v=0 --check-for-update-interval=50Reviewer Checklist: