Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add google analytics polyfill, fixes brave/brave-browser#4402 (uplift to 0.66.x) #2736

Merged
merged 1 commit into from
Jun 24, 2019
Merged

add google analytics polyfill, fixes brave/brave-browser#4402 (uplift to 0.66.x) #2736

merged 1 commit into from
Jun 24, 2019

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Jun 19, 2019 •
edited by bsclifton
Loading

Uplift of #2488

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds self-assigned this Jun 19, 2019
@brave-builds brave-builds added this to the 0.66.x - Beta milestone Jun 19, 2019
srirambv
srirambv approved these changes Jun 24, 2019
View reviewed changes
Copy link
Contributor

@srirambv srirambv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved uplift to 0.66.x. CI failure isn't related to the PR hence approving uplift. Please update the milestone and labels accordingly

@pes10k pes10k merged commit 93c9f89 into 0.66.x Jun 24, 2019
@bsclifton bsclifton deleted the pr2488_inject-ubo-google-analytics-code_0.66.x branch June 24, 2019 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srirambv srirambv srirambv approved these changes

@bbondy bbondy Awaiting requested review from bbondy

@bsclifton bsclifton Awaiting requested review from bsclifton

@kjozwiak kjozwiak Awaiting requested review from kjozwiak

@rebron rebron Awaiting requested review from rebron

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
0.66.x - Release
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @srirambv @pes10k @brave-browser-releases