Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Untie more network callbacks from net::URLRequest #2908

Merged
merged 5 commits into from
Jul 22, 2019

Conversation

iefremov
Copy link
Contributor

@iefremov iefremov commented Jul 12, 2019

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@iefremov iefremov requested review from bridiver and yrliou July 12, 2019 17:28
bridiver
bridiver previously approved these changes Jul 12, 2019
yrliou
yrliou previously approved these changes Jul 12, 2019
@iefremov iefremov dismissed stale reviews from yrliou and bridiver via fcf146d July 15, 2019 09:07
@iefremov iefremov force-pushed the shields_no_url_request_2 branch 2 times, most recently from 615eba8 to 2edb55b Compare July 17, 2019 10:06
@iefremov iefremov merged commit a1559f4 into master Jul 22, 2019
@iefremov iefremov deleted the shields_no_url_request_2 branch July 22, 2019 16:44
@bsclifton bsclifton added this to the 0.69.x - Release milestone Sep 9, 2019
bsclifton pushed a commit that referenced this pull request Sep 9, 2019
Untie more network callbacks from net::URLRequest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants