Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds callback to RemoveRecurring tip #2970

Merged
merged 1 commit into from
Jul 23, 2019
Merged

Adds callback to RemoveRecurring tip #2970

merged 1 commit into from
Jul 23, 2019

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jul 22, 2019 •
edited
Loading

Resolves brave/brave-browser#5145

Submitter Checklist:

Test Plan:

  • enable rewards
  • add recurring tip for one publisher
  • go to rewards page and make sure that you can remove that publisher

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc added this to the 0.69.x - Nightly milestone Jul 22, 2019
@NejcZdovc NejcZdovc requested review from tmancey and emerick July 22, 2019 13:02
@NejcZdovc NejcZdovc requested a review from kylehickinson as a code owner July 22, 2019 13:02
@NejcZdovc NejcZdovc self-assigned this Jul 22, 2019
@NejcZdovc NejcZdovc force-pushed the remove-tip-callback branch from 0eacc8f to 8bec5f9 Compare July 22, 2019 13:07
@NejcZdovc NejcZdovc force-pushed the remove-tip-callback branch from 8bec5f9 to 215a897 Compare July 22, 2019 13:28
kylehickinson
kylehickinson previously approved these changes Jul 22, 2019
View reviewed changes
Copy link
Collaborator

@kylehickinson kylehickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iOS looks good

@NejcZdovc NejcZdovc force-pushed the remove-tip-callback branch from 215a897 to 5001fdc Compare July 22, 2019 13:38
kylehickinson
kylehickinson previously approved these changes Jul 22, 2019
View reviewed changes
emerick
emerick previously approved these changes Jul 22, 2019
View reviewed changes
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NejcZdovc NejcZdovc dismissed stale reviews from emerick and kylehickinson via 63a4f07 July 22, 2019 13:41
@NejcZdovc NejcZdovc force-pushed the remove-tip-callback branch 2 times, most recently from 63a4f07 to 8e83ff5 Compare July 22, 2019 16:43
emerick
emerick previously approved these changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NejcZdovc NejcZdovc force-pushed the remove-tip-callback branch from 8e83ff5 to dabaf38 Compare July 23, 2019 09:16
emerick
emerick previously approved these changes Jul 23, 2019
View reviewed changes
@NejcZdovc NejcZdovc force-pushed the remove-tip-callback branch from dabaf38 to 0b0627b Compare July 23, 2019 09:50
@tmancey tmancey self-requested a review July 23, 2019 09:51
tmancey
tmancey previously approved these changes Jul 23, 2019
View reviewed changes
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

kylehickinson
kylehickinson previously approved these changes Jul 23, 2019
View reviewed changes
@NejcZdovc NejcZdovc dismissed stale reviews from kylehickinson and tmancey via 0aaff23 July 23, 2019 13:53
@NejcZdovc NejcZdovc force-pushed the remove-tip-callback branch from 0b0627b to 0aaff23 Compare July 23, 2019 13:53
@NejcZdovc NejcZdovc merged commit cba8230 into master Jul 23, 2019
@NejcZdovc NejcZdovc deleted the remove-tip-callback branch July 23, 2019 18:38
@kylehickinson kylehickinson mentioned this pull request Jul 25, 2019
Merged
hashmi-waseem pushed a commit to hashmi-waseem/brave-core that referenced this pull request May 6, 2024
@bridiver
Merge pull request brave#1546 from brave/issues/2970
8ff34d5 
protect unsafe multithreaded access to httpse cache
hashmi-waseem pushed a commit to hashmi-waseem/brave-core that referenced this pull request May 6, 2024
@bridiver
Merge pull request brave#1550 from brave/issues/2970-0.61.x
c605b4f 
protect unsafe multithreaded access to httpse cache
hashmi-waseem pushed a commit to hashmi-waseem/brave-core that referenced this pull request May 6, 2024
@bridiver
Merge pull request brave#1563 from brave/issues/2970-2-0.61.x
0e86565 
ensure that `browser` is never null
hashmi-waseem pushed a commit to hashmi-waseem/brave-core that referenced this pull request May 6, 2024
@bridiver
Merge pull request brave#1546 from brave/issues/2970
7ab9d43 
protect unsafe multithreaded access to httpse cache
hashmi-waseem pushed a commit to hashmi-waseem/brave-core that referenced this pull request May 6, 2024
@bridiver
Merge pull request brave#1549 from brave/issues/2970-0.60.x
76687fc 
protect unsafe multithreaded access to httpse cache
hashmi-waseem pushed a commit to hashmi-waseem/brave-core that referenced this pull request May 6, 2024
@bridiver
Merge pull request brave#1562 from brave/issues/2970-2-0.60.x
8d315c4 
ensure that `browser` is never null
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylehickinson kylehickinson kylehickinson approved these changes

@emerick emerick emerick left review comments

@tmancey tmancey tmancey left review comments

Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards
Projects
None yet
Milestone
0.69.x-backup
Development

Successfully merging this pull request may close these issues.

Add callback to RemoveRecurringTip
4 participants
@NejcZdovc @kylehickinson @tmancey @emerick