Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work around Chromium's new in-line constructor size limits.
Get base::StringPiece forward declaration in url_auth_util.h.
Use `#if !defined(BRAVE_CHROMIUM_BUILD)', not #if 0.
Override and include, rather than patch, net_log_event_type_list.h.
Override and include host_port_pair.cc to reduce BUILD.gn diffs.
Override and include url_util.cc rather than add url_auth_util.cc.
Override and include socks5_client_socket.cc.
Don't patch HostPortPair(host, port) constructor.
Instead, use a different constructor in proxy_server.cc.
This adds another patch to our maintenance burden, but it avoids
changing the semantics of (and adding parsing overhead to) the
constructor that is used in a bazillion places all over Chromium.
This is a replacement for #290, in which during squashing or something I lost two files 9socks5_client_socket.cc/h) that were critical to the whole thing.
fix brave/brave-browser#666
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist: