Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 6007: Add temporary fingerprinting exception for 1password.com #3425

Merged
merged 1 commit into from
Sep 18, 2019

Conversation

jumde
Copy link
Contributor

@jumde jumde commented Sep 13, 2019

Fix brave/brave-browser#6007

Submitter Checklist:

Test Plan:

  1. Navigate to https://bravepassword.1password.com/security/sign-in-attempts
  2. Login with 1Password Test account in the team vault
  3. Verify that there are no Cross Site Device Recognition attempts in shields from map.1passwordservices.com

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@jumde jumde self-assigned this Sep 13, 2019
@jumde jumde force-pushed the 1password_exception branch from cb6b432 to d72db02 Compare September 13, 2019 06:15
@jumde jumde force-pushed the 1password_exception branch 3 times, most recently from a521929 to 2d69fd5 Compare September 17, 2019 03:07
@jumde jumde force-pushed the 1password_exception branch 5 times, most recently from 582e209 to efb4ebf Compare September 18, 2019 07:59
@jumde jumde force-pushed the 1password_exception branch from efb4ebf to d738e0c Compare September 18, 2019 12:12
@jumde jumde merged commit 4621aa3 into master Sep 18, 2019
@jumde jumde deleted the 1password_exception branch September 18, 2019 23:56
@jumde jumde added this to the 0.72.x - Nightly milestone Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add fingerprinting exception for 1password.com
2 participants