Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect against RenderFrameHost swapping out #376

Merged
merged 1 commit into from
Aug 30, 2018
Merged

Protect against RenderFrameHost swapping out #376

merged 1 commit into from
Aug 30, 2018

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Aug 30, 2018

Fix brave/brave-browser#708

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Needed or QA/No-QA-Needed) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@bbondy bbondy self-assigned this Aug 30, 2018
@bbondy bbondy requested a review from bridiver August 30, 2018 18:14
@bbondy bbondy merged commit e4f896b into master Aug 30, 2018
@bsclifton bsclifton deleted the back-button branch September 26, 2018 05:44
petemill pushed a commit to petemill/brave-core that referenced this pull request Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Browser webview crash when navigating back on any page
2 participants