Fix master debug build failure from BraveActionAPIDependencyManager #3796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petemill
reviewed
Oct 27, 2019
| if (base::CommandLine::ForCurrentProcess()->HasSwitch( | ||
| kDumpBraveActionaAPIDependencyGraphFlag)) { | ||
| base::FilePath dot_file = | ||
| static_cast<const SimpleFactoryKey*>(context)->GetPath().AppendASCII( |
There was a problem hiding this comment.
Context is a Browser. Can it still be cast to SimpleFactoryKey?
Otherwise I doubt we would ever use this flag as this architecture stands - there are no service dependencies so if it's any more complicated than this, we can just stub it out since we're using KeyedService here as a utility to key BraveActionAPI on Browser
There was a problem hiding this comment.
Oh, you're right. it's wrong casting. It will cause runtime crash.
Also, made it as a stub impl.
There was a missing abstract method that we missed only for debug build.
simonhong
force-pushed
the
fix_build_error
branch
from
b632a84 to
baf343c
Compare
petemill
approved these changes
Oct 28, 2019
fmarier
pushed a commit
that referenced
this pull request
Oct 29, 2019
bsclifton
pushed a commit
that referenced
this pull request
Nov 4, 2019
Fix master debug build failure from BraveActionAPIDependencyManager
bsclifton
pushed a commit
that referenced
this pull request
Nov 4, 2019
Fix master debug build failure from BraveActionAPIDependencyManager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a missing abstract method that used only for debug build.
Fix brave/brave-browser#6628
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.