Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload after changing autoplay settings #3864

Merged
merged 2 commits into from
Nov 5, 2019

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Nov 3, 2019

Fix brave/brave-browser#6700

Submitter Checklist:

Test Plan:

See issues

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Page is reloaded when user clickes Done button in content settings bubble
or bubble is closed.
@simonhong simonhong added this to the 0.73.x - Nightly milestone Nov 3, 2019
@simonhong simonhong requested review from bsclifton and darkdh November 3, 2019 22:41
@simonhong simonhong self-assigned this Nov 3, 2019
@simonhong simonhong changed the title Reload after changing settings Reload after changing autoplay settings Nov 4, 2019
@simonhong
Copy link
Member Author

kindly ping to @darkdh :)

@simonhong simonhong merged commit 8da86f6 into master Nov 5, 2019
@simonhong simonhong deleted the reload_after_changing_settings branch November 5, 2019 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

auto refresh page when selecting 'Always allow autoplay on..." setting
2 participants