Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating empty wallet messaging for unsupported regions (0.72) #3910

Merged
merged 1 commit into from
Nov 11, 2019
Merged

Updating empty wallet messaging for unsupported regions (0.72) #3910

merged 1 commit into from
Nov 11, 2019

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Nov 7, 2019

@ryanml
Merge pull request #3849 from brave/fix-6604
111a259 
Updating empty wallet message for unsupported regions
@ryanml ryanml added this to the 0.72.x - Beta milestone Nov 7, 2019
@ryanml ryanml requested a review from a team November 7, 2019 15:38
@ryanml ryanml requested a review from NejcZdovc as a code owner November 7, 2019 15:38
@ryanml ryanml self-assigned this Nov 7, 2019
@NejcZdovc NejcZdovc removed their request for review November 8, 2019 12:39
@kjozwiak
Copy link
Member

kjozwiak commented Nov 10, 2019 •
edited
Loading

Restarting on Linux due to https://ci.brave.com/job/brave-browser-build-pr/job/uplift-6604-72/2/execution/node/362/log/ failing.

@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows labels Nov 10, 2019
kjozwiak
kjozwiak approved these changes Nov 11, 2019
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 0.72.x approved after deliberating with @brave/uplift-approvers. This fix was also uplifted into #3911 (0.73.x) & #3909 (0.71.x) and will need to be uplifted into 0.72.x. Both CI/Jenkins and CI/Travis passed after several restarts.

@kjozwiak kjozwiak merged commit 35b3bf0 into 0.72.x Nov 11, 2019
@kjozwiak kjozwiak deleted the uplift-6604-72 branch November 11, 2019 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@ryanml ryanml

Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 feature/rewards
Projects
None yet
Milestone
1.1.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanml @kjozwiak