Promotion expiration

[masparrow]

Resolves brave/brave-browser#6947

Submitter Checklist:

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Verified that these changes build without errors on
  • Android
  • iOS
  • Linux
  • macOS
  • Windows
• Verified that these changes pass automated tests (unit, browser, security tests) on
  • iOS
  • Linux
  • macOS
  • Windows
• Verified that all lint errors/warnings are resolved (npm run lint)
• Ran git rebase master (if needed).
• Ran git rebase -i to squash commits (if needed).
• Tagged reviewers and labelled the pull request as needed.
• Request a security/privacy review as needed.
• Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone
• Public documentation has been updated as necessary. For instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protection-Mode
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Custom-Headers
  • https://github.com/brave/brave-browser/wiki/Web-compatibility-issues-with-tracking-protection
  • https://github.com/brave/brave-browser/wiki/QA-Guide

Test Plan:

1. Clean install
2. Join rewards, and claim a grant
3. Check your balance (17.5 BAT)
4. Close Brave
5. Edit the promotion expiresAt in the database publisher_info_db to be in the past (i.e. 946684800 for 00:00:00 01/01/2000)
6. Launch Brave
7. Check your balance (should now be 0.0 BAT)
8. There should be no details button (to show more grants) in wallet panel

Reviewer Checklist:

• New files have MPL-2.0 license header.
• Request a security/privacy review as needed.
• Adequate test coverage exists to prevent regressions
• Verify test plan is specified in PR before merging to source

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on.
• All relevant documentation has been updated.

[NejcZdovc]

can you please add browser test for it?

[NejcZdovc]

After step 7 in the test plan I checked if details button is gone. It's gone on settings page, but I still see promotion in the panel.

Panel

Settings page

[masparrow]

can you please add browser test for it?

Will do, and I'll investigate the promotions thing - I spotted that but thought it was correct as it was a history of the claim. I'm guessing data is cached elsewhere.

[NejcZdovc]

spacing was fixed for this function

[kylehickinson]

iOS db implementation will be migrated to native libs in #4087

[NejcZdovc]

CI failed on audit-network, not related.

[tmancey]

LGTM++