Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add migration flow for old grants to new promotions #4101

Merged
merged 1 commit into from
Dec 3, 2019
Merged

Add migration flow for old grants to new promotions #4101

merged 1 commit into from
Dec 3, 2019

Conversation

masparrow
Copy link
Contributor

@masparrow masparrow commented Nov 28, 2019 •
edited by NejcZdovc
Loading

Resolves brave/brave-browser#6937

Submitter Checklist:

Test Plan:

  1. Clean install Brave 1.0 from the release channel
  2. Join rewards
  3. Claim a grant
  4. Record the BAT balance
  5. Quit Brave
  6. Locate the profile (OSX = ~/Library/Application Support/BraveSoftware/Brave-Browser)
  7. Copy this profile as 'Brave-Browser-Development' (delete any existing 'Brave-Browser-Development' first)
  8. Launch the development build from this PR
  9. Confirm your BAT balance is as expected from step 4.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@masparrow masparrow added the CI/skip Do not run CI builds (except noplatform) label Nov 28, 2019
@masparrow masparrow requested a review from NejcZdovc November 28, 2019 09:25
@NejcZdovc NejcZdovc added feature/rewards and removed CI/skip Do not run CI builds (except noplatform) labels Nov 28, 2019
@NejcZdovc NejcZdovc mentioned this pull request Nov 28, 2019
Closed
13 tasks
@masparrow masparrow force-pushed the issues/6937 branch 3 times, most recently from d5f03c0 to 3079eff Compare December 2, 2019 15:59
@NejcZdovc NejcZdovc added this to the 1.3.x - Nightly milestone Dec 3, 2019
@NejcZdovc NejcZdovc marked this pull request as ready for review December 3, 2019 06:26
@NejcZdovc NejcZdovc requested a review from gdregalo as a code owner December 3, 2019 06:26
@NejcZdovc
Copy link
Contributor

CI failed on test-install. Not related to this PR

gdregalo
gdregalo reviewed Dec 3, 2019
View reviewed changes
vendor/bat-native-ledger/src/bat/ledger/internal/promotion/promotion.cc
}
if (item->legacy_claimed) {
item->status = ledger::PromotionStatus::CLAIMED;
ClaimTokens(item->Clone(), [](const ledger::Result _){});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a _ symbol after Result.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is needed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per:
https://google.github.io/styleguide/cppguide.html#Function_Declarations_and_Definitions
A parameter name may be omitted only if the parameter is not used in the function's definition.
The _ is considered as a special symbol. We usually use it as trailing part in class/struct members names.

gdregalo
gdregalo approved these changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@gdregalo gdregalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving.
Please address (https://github.com/brave/brave-core/pull/4101/files#r353304718) in next PR.

@NejcZdovc NejcZdovc merged commit 38a1984 into master Dec 3, 2019
@NejcZdovc NejcZdovc deleted the issues/6937 branch December 3, 2019 19:35
@btlechowski btlechowski mentioned this pull request Dec 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NejcZdovc NejcZdovc NejcZdovc approved these changes

@gdregalo gdregalo gdregalo approved these changes

Assignees

@masparrow masparrow

Labels
feature/rewards
Projects
None yet
Milestone
1.3.x - Release
Development

Successfully merging this pull request may close these issues.

Add migration flow for old grants to new promotions
3 participants
@masparrow @NejcZdovc @gdregalo