Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Rewards to now respect main toggle and autocontribute toggle #419

Merged
merged 1 commit into from
Sep 12, 2018
Merged

Updated Rewards to now respect main toggle and autocontribute toggle #419

merged 1 commit into from
Sep 12, 2018

Conversation

jasonrsadler
Copy link
Contributor

@jasonrsadler jasonrsadler commented Sep 7, 2018

Resolves brave-intl/bat-native-ledger#58

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Needed or QA/No-QA-Needed) to include the closed issue in milestone

Test Plan:

  1. Start Brave with a clean profile.
  2. Opt in to rewards.
  3. Navigate to a web site and wait the required time.
  4. Verify site was added to autocontribute table.
  5. Disable autocontribute and repeat step 3.
  6. Verify site was not added to autocontribute table.
  7. Enable autocontribute and disable rewards and repeat step 3 and 6.
  8. Repeat tests by adding the step of disabling/enabling rewards and/or autocontribute, then closing browser and reopening to verify that sites were added/not added

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@jasonrsadler
Copy link
Contributor Author

Blocked on brave-intl/bat-native-ledger#87

@jasonrsadler
Copy link
Contributor Author

Ready for Review

@jasonrsadler jasonrsadler deleted the respect-autocontribute branch September 11, 2018 14:33
@jasonrsadler jasonrsadler restored the respect-autocontribute branch September 11, 2018 14:33
@jasonrsadler jasonrsadler reopened this Sep 11, 2018
@jasonrsadler
Copy link
Contributor Author

Pending resolve on DEPS

Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

cezaraugusto added a commit that referenced this pull request Aug 1, 2019
…ields-again"

This reverts commit 9568cc934ec7f4fdc935a8beb1474636f59f8ede, reversing
changes made to f451638696a05f43bb9e2e513e09f414909aed2f.
cezaraugusto added a commit that referenced this pull request Aug 1, 2019
… definition

Revert "Revert "Merge pull request #419 from brave/shields-again""

This reverts commit 59b438ad7e754ea00160331ca91dc8ba91530d1e.
cezaraugusto added a commit that referenced this pull request Aug 13, 2019
…ields-again"

This reverts commit 9568cc934ec7f4fdc935a8beb1474636f59f8ede, reversing
changes made to f451638696a05f43bb9e2e513e09f414909aed2f.
cezaraugusto added a commit that referenced this pull request Aug 13, 2019
… definition

Revert "Revert "Merge pull request #419 from brave/shields-again""

This reverts commit 59b438ad7e754ea00160331ca91dc8ba91530d1e.
cezaraugusto added a commit that referenced this pull request Aug 29, 2019
…ields-again"

This reverts commit 9568cc934ec7f4fdc935a8beb1474636f59f8ede, reversing
changes made to f451638696a05f43bb9e2e513e09f414909aed2f.
cezaraugusto added a commit that referenced this pull request Aug 29, 2019
… definition

Revert "Revert "Merge pull request #419 from brave/shields-again""

This reverts commit 59b438ad7e754ea00160331ca91dc8ba91530d1e.
petemill pushed a commit that referenced this pull request Sep 10, 2019
…#419 from brave/shields-again"

This reverts commit 9568cc934ec7f4fdc935a8beb1474636f59f8ede, reversing
changes made to f451638696a05f43bb9e2e513e09f414909aed2f.
petemill pushed a commit that referenced this pull request Sep 10, 2019
…brave-ui until final definition

Revert "Revert "Merge pull request #419 from brave/shields-again""

This reverts commit 59b438ad7e754ea00160331ca91dc8ba91530d1e.
NejcZdovc pushed a commit that referenced this pull request Sep 19, 2019
… brave/shields-again"

This reverts commit 9568cc934ec7f4fdc935a8beb1474636f59f8ede, reversing
changes made to f451638696a05f43bb9e2e513e09f414909aed2f.
NejcZdovc pushed a commit that referenced this pull request Sep 19, 2019
…til final definition

Revert "Revert "Merge pull request #419 from brave/shields-again""

This reverts commit 59b438ad7e754ea00160331ca91dc8ba91530d1e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Respect auto contribute
5 participants