Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix android_chrome_strings XTBs #4232

Merged
merged 1 commit into from
Dec 14, 2019
Merged

Fix android_chrome_strings XTBs #4232

merged 1 commit into from
Dec 14, 2019

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Dec 13, 2019

Fixes brave/brave-browser#7378

  • Updated transifex.py with the missing mapping of
    android_chrome_strings which is needed to upload existing
    translations to Transifex.

  • Deleted existing XTB files under brave, pushed to Transifex
    so that the existing translations were uploaded.

  • Ran npm run delete_string_translations for strings containing
    incorrect translations of private -> incognito. The corrected
    translations will be ordered separately.

  • Pulled translations from Transifex which resulted in the changes in
    XTBs in this commit.

  • Lint fixes in transifex.py

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@mkarolin mkarolin added this to the 1.4.x - Nightly milestone Dec 13, 2019
@mkarolin mkarolin self-assigned this Dec 13, 2019
@mkarolin mkarolin added CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Dec 13, 2019
@mkarolin mkarolin force-pushed the maxk-fix-android-xtbs branch from 2c80cc7 to 57c9c69 Compare December 13, 2019 20:38
Fixes brave/brave-browser#7378

- Updated transifex.py with the missing mapping of
  android_chrome_strings which is needed to upload existing
  translations to Transifex.

- Deleted existing XTB files under brave, pushed to Transifex
  so that the existing translations were uploaded.

- Ran npm run delete_string_translations for strings containing
  incorrect translations of private -> incognito. The corrected
  translations will be ordered separately.

- Pulled translations from Transifex which resulted in the changes in
  XTBs in this commit.

- Lint fixes in transifex.py
@mkarolin mkarolin force-pushed the maxk-fix-android-xtbs branch from 57c9c69 to 1e593b5 Compare December 13, 2019 22:10
@mkarolin mkarolin added CI/skip Do not run CI builds (except noplatform) and removed CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Dec 13, 2019
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@mkarolin mkarolin merged commit f7395e6 into master Dec 14, 2019
@mkarolin mkarolin deleted the maxk-fix-android-xtbs branch December 14, 2019 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip Do not run CI builds (except noplatform)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix android_chrome_strings localization on Transifex
2 participants