Refactor balance report #4237
Merged
Refactor balance report #4237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NejcZdovc
force-pushed
the
balance-report
branch
from
cedc1c0 to
9c531a3
Compare
NejcZdovc
commented
Dec 16, 2019
NejcZdovc
force-pushed
the
balance-report
branch
2 times, most recently
from
5794012 to
a9c856f
Compare
NejcZdovc
force-pushed
the
balance-report
branch
from
a9c856f to
08cabcc
Compare
NejcZdovc
force-pushed
the
balance-report
branch
from
08cabcc to
ba8f3d6
Compare
Brandon-T
approved these changes
Dec 16, 2019
NejcZdovc
force-pushed
the
balance-report
branch
4 times, most recently
from
40f4396 to
a7a1aee
Compare
32 tasks
masparrow
approved these changes
Dec 18, 2019
|
|
||
| newReports[report.first] = newReport; | ||
| void LedgerToServiceBalanceReport( | ||
| ledger::BalanceReportInfoPtr report, |
There was a problem hiding this comment.
Perhaps Obtain/Get/BalanceReportFromLedger or similar...
There was a problem hiding this comment.
this is conversion from one type to another
There was a problem hiding this comment.
ConvertLedgerReportToBalancereport then?
vendor/bat-native-ledger/src/bat/ledger/internal/state/report_balance_state.cc
Outdated
Show resolved
Hide resolved
| @@ -1261,7 +1261,7 @@ public void OnGetCurrentBalanceReport(String[] report) { | |||
| tv.setText(toInsert); | |||
| tvUSD.setText(textUSD); | |||
| } | |||
| if (!report[i].equals("0")) { | |||
| if (report[i] != 0) { | |||
gdregalo
approved these changes
Dec 18, 2019
NejcZdovc
force-pushed
the
balance-report
branch
from
e4ee1b5 to
ff44fa8
Compare
|
@Brandon-T checked iOS code as @kylehickinson is on PTO |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#7329
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
plan 1:
plan 2:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.