Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional phase of Brave Ads regions #4427

Merged
merged 1 commit into from
Apr 7, 2020
Merged

Additional phase of Brave Ads regions #4427

merged 1 commit into from
Apr 7, 2020

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Jan 24, 2020

Fixes brave/brave-browser#7817

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@tmancey tmancey added this to the 1.5.x - Nightly milestone Jan 24, 2020
@tmancey tmancey requested a review from gdregalo as a code owner January 24, 2020 18:38
@tmancey tmancey self-assigned this Jan 24, 2020
@tmancey tmancey requested a review from jsecretan January 24, 2020 18:41
bsclifton
bsclifton reviewed Jan 24, 2020
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving per conversation with @tmancey 👍

@tmancey tmancey removed this from the 1.5.x - Nightly milestone Feb 3, 2020
@tmancey tmancey force-pushed the issues/7817 branch 2 times, most recently from feed31f to 556cea2 Compare February 16, 2020 12:00
NejcZdovc
NejcZdovc approved these changes Feb 16, 2020
View reviewed changes
Copy link
Contributor

@NejcZdovc NejcZdovc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rewards code looks good

emerick
emerick approved these changes Feb 16, 2020
View reviewed changes
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmancey tmancey force-pushed the issues/7817 branch 3 times, most recently from c34061b to 5aedd0c Compare February 27, 2020 23:23
@tmancey tmancey force-pushed the issues/7817 branch 3 times, most recently from c00b304 to 0b916dc Compare March 4, 2020 00:35
@tmancey tmancey force-pushed the issues/7817 branch 3 times, most recently from 73f9963 to b4c9391 Compare March 26, 2020 07:31
@tmancey tmancey merged commit 10a7bb1 into master Apr 7, 2020
@tmancey tmancey deleted the issues/7817 branch April 7, 2020 09:53
@tmancey tmancey added this to the 1.9.x - Nightly milestone Apr 7, 2020
@LaurenWags LaurenWags mentioned this pull request May 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdregalo gdregalo gdregalo approved these changes

@masparrow masparrow masparrow approved these changes

@NejcZdovc NejcZdovc NejcZdovc approved these changes

@emerick emerick emerick approved these changes

@bsclifton bsclifton bsclifton approved these changes

@jsecretan jsecretan jsecretan approved these changes

Assignees

@tmancey tmancey

Labels
feature/ads
Projects
None yet
Milestone
1.9.x - Release
Development

Successfully merging this pull request may close these issues.

Additional phase of Brave Ads regions
7 participants
@tmancey @jsecretan @bsclifton @emerick @NejcZdovc @masparrow @gdregalo