Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Tab Page WebUI: Prompt to turn on Brave Ads instead of Brave Rewards when Brave Ads is off #4447

Merged
merged 1 commit into from
Jan 28, 2020

Conversation

petemill
Copy link
Member

@petemill petemill commented Jan 28, 2020

Fix brave/brave-browser#7939

Test Plan:

On brave/brave-browser#7939
And in addition:

  1. Clean profile, keep Rewards OFF
  2. Enable flag for SNTP. Restart.
  3. Open new tab until you see a SNTP.

Expected: Rewards widget shows "Turn on Brave Rewards to claim your share"

Submitter Checklist:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@petemill petemill requested review from bsclifton and ryanml January 28, 2020 06:11
@petemill petemill self-assigned this Jan 28, 2020
@petemill petemill merged commit e3a615f into master Jan 28, 2020
@petemill petemill deleted the ntp-sbw-ads-off-string branch January 28, 2020 14:54
petemill added a commit that referenced this pull request Jan 29, 2020
New Tab Page WebUI: Prompt to turn on Brave Ads instead of Brave Rewards when Brave Ads is off
This was referenced Jan 29, 2020
petemill added a commit that referenced this pull request Jan 29, 2020
New Tab Page WebUI: Prompt to turn on Brave Ads instead of Brave Rewards when Brave Ads is off
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NTP SI - message says to Turn on BR when Rewards are already on, should say turn on Ads
2 participants