Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stats updater to accept any 2XX HTTP response codes as success #462

Merged
merged 1 commit into from
Sep 17, 2018
Merged

Fix stats updater to accept any 2XX HTTP response codes as success #462

merged 1 commit into from
Sep 17, 2018

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Sep 17, 2018 •
edited
Loading

Fixes brave/brave-browser#1154

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Needed or QA/No-QA-Needed) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@emerick emerick self-assigned this Sep 17, 2018
@emerick emerick requested a review from bbondy September 17, 2018 20:26
@emerick emerick merged commit 764a32a into master Sep 17, 2018
emerick added a commit that referenced this pull request Sep 17, 2018
@emerick
Merge pull request #462 from brave/brave-stats-http-success
8cc3334 
Fix stats updater to accept any 2XX HTTP response codes as success
@emerick
Copy link
Contributor Author

emerick commented Sep 17, 2018 •
edited
Loading

master: f8f334c
0.55.x: 8cc3334

@emerick emerick deleted the brave-stats-http-success branch September 17, 2018 20:44
@bbondy bbondy added this to the 0.55.x - Release milestone Jan 14, 2019
fmarier pushed a commit that referenced this pull request Oct 29, 2019
@yrliou
Merge pull request #462 from brave/branding_settings_history
1b61377 
Branding in settings and history pages
petemill pushed a commit that referenced this pull request Jul 27, 2020
@yrliou
Merge pull request #462 from brave/branding_settings_history
8b152bb 
Branding in settings and history pages
petemill pushed a commit that referenced this pull request Jul 28, 2020
@yrliou
Merge pull request #462 from brave/branding_settings_history
b9263e1 
Branding in settings and history pages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbondy bbondy bbondy approved these changes

Assignees

@emerick emerick

Labels
None yet
Projects
None yet
Milestone
0.55.x - Release
Development

Successfully merging this pull request may close these issues.

Consider all success codes as successful for BraveStatsUpdater
2 participants
@emerick @bbondy