Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Brave Ads database in preparation for merging Publisher Ads #4698

Merged
merged 1 commit into from
Feb 20, 2020

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Feb 20, 2020

Resolves brave/brave-browser#8334

Submitter Checklist:

Test Plan:

Confirm ads are shown

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@tmancey tmancey added this to the 1.7.x - Nightly milestone Feb 20, 2020
@tmancey tmancey self-assigned this Feb 20, 2020
@tmancey tmancey force-pushed the issues/8334 branch 2 times, most recently from d7ed1d8 to b176828 Compare February 20, 2020 19:40
@tmancey tmancey requested review from emerick and NejcZdovc February 20, 2020 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Brave Ads database in preparation for merging Publisher Ads
2 participants