Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 80.0.3987.116 to Chromium 80.0.3987.122 (1.5.x). #4728

Merged
merged 1 commit into from
Feb 26, 2020

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Feb 24, 2020

Fixes brave/brave-browser#8379
Related PR: brave/brave-browser#8386
Uplift from #4723

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Upgrade from Chromium 80.0.3987.116 to Chromium 80.0.3987.122.
@mkarolin
Copy link
Collaborator Author

CI: Windows, Linux, and Android succeeded.
Mac and iOS failed on checkout. Will rerun.

@mkarolin mkarolin added CI/skip-android Do not run CI builds for Android CI/skip-linux CI/skip-ios Do not run CI builds for iOS labels Feb 25, 2020
@mkarolin
Copy link
Collaborator Author

CI: iOS succeeded. Mac failed in build (timestamping script) - will rerun.

@mkarolin
Copy link
Collaborator Author

Mac CI hit brave/brave-browser#8331. After rerunning with a clean workspace, unit and browser tests failed to build due to brave/brave-browser#6515. Rerunning again ended up with brave/brave-browser#8331 again. @kjozwiak, should these just be considered unrelated issues?

@mkarolin
Copy link
Collaborator Author

MacOS CI passed.

@mkarolin mkarolin requested a review from a team February 26, 2020 15:55
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.5.x approved after deliberating with @brave/uplift-approvers. Both CI/Jenkins and CI/Travis passed without any issues. Please make sure that all the labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit 0065ccc into 1.5.x Feb 26, 2020
@kjozwiak kjozwiak deleted the 80.0.3987.122-1.5.x branch February 26, 2020 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-network-audit Run network-audit CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants