Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix production/staging flag #485

Merged
merged 1 commit into from
Sep 26, 2018
Merged

fix production/staging flag #485

merged 1 commit into from
Sep 26, 2018

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Sep 21, 2018

Resolves brave/brave-browser#1171

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Needed or QA/No-QA-Needed) to include the closed issue in milestone

Test Plan:

Create release build. Make sure that wallet is connecting to production server

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@NejcZdovc
Copy link
Contributor Author

please do not merge, will merge it when time is right

@NejcZdovc NejcZdovc merged commit c65cccd into master Sep 26, 2018
@NejcZdovc
Copy link
Contributor Author

master c65cccd
0.55.x ab79735

NejcZdovc added a commit that referenced this pull request Sep 26, 2018
@bbondy
Copy link
Member

bbondy commented Sep 26, 2018

Added label merged/0.55.x

@NejcZdovc NejcZdovc deleted the rewards-production branch September 27, 2018 13:38
@bbondy bbondy added this to the 0.55.x - Release milestone Jan 14, 2019
petemill pushed a commit to petemill/brave-core that referenced this pull request Jul 3, 2019
This reverts commit dbc5cda1cc182fca4813b129176a629c37d8d679, reversing
changes made to 0139aa32246af6d4e4ec0daea79945966dd79999.
petemill pushed a commit to petemill/brave-core that referenced this pull request Jul 5, 2019
…e-background-img

Change Background Settings for New Tabs Page
petemill pushed a commit to petemill/brave-core that referenced this pull request Jul 5, 2019
…ve/toggle-background-img"

This reverts commit dbc5cda1cc182fca4813b129176a629c37d8d679, reversing
changes made to 0139aa32246af6d4e4ec0daea79945966dd79999.
petemill pushed a commit to petemill/brave-core that referenced this pull request Jul 5, 2019
…t-485

Revert "Merge pull request brave#485 from brave/toggle-background-img"
petemill pushed a commit that referenced this pull request Jul 5, 2019
…ggle-background-img"

This reverts commit dbc5cda1cc182fca4813b129176a629c37d8d679, reversing
changes made to 0139aa32246af6d4e4ec0daea79945966dd79999.
NejcZdovc added a commit that referenced this pull request Sep 19, 2019
… brave/toggle-background-img"

This reverts commit dbc5cda1cc182fca4813b129176a629c37d8d679, reversing
changes made to 0139aa32246af6d4e4ec0daea79945966dd79999.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

staging env is being used for wallets
4 participants