Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes ntp blank page #5066

Merged
merged 1 commit into from
Mar 26, 2020
Merged

Fixes ntp blank page #5066

merged 1 commit into from
Mar 26, 2020

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Mar 26, 2020 •
edited
Loading

Resolves brave/brave-browser#8867

Submitter Checklist:

Test Plan:

defined in brave/brave-browser#8867

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc self-assigned this Mar 26, 2020
@NejcZdovc NejcZdovc added this to the 1.8.x - Nightly milestone Mar 26, 2020
@NejcZdovc NejcZdovc force-pushed the ntp-blank branch 3 times, most recently from c018239 to 4681204 Compare March 26, 2020 07:12
NejcZdovc
NejcZdovc commented Mar 26, 2020
View reviewed changes
components/brave_rewards/resources/android_page/utils.ts
@@ -40,15 +40,6 @@ export const generateContributionMonthly = (list: number[], rates: Record<string
})
}

export const tipsTotal = (report: Rewards.BalanceReport) => {
Copy link
Contributor Author

@NejcZdovc NejcZdovc Mar 26, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not used

NejcZdovc
NejcZdovc commented Mar 26, 2020
View reviewed changes
components/brave_rewards/resources/page/utils.ts
@@ -40,15 +40,6 @@ export const generateContributionMonthly = (list: number[], rates: Record<string
})
}

export const tipsTotal = (report: Rewards.BalanceReport) => {
Copy link
Contributor Author

@NejcZdovc NejcZdovc Mar 26, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not used

@NejcZdovc NejcZdovc marked this pull request as ready for review March 26, 2020 07:12
ryanml
ryanml approved these changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@ryanml ryanml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

simonhong
simonhong approved these changes Mar 26, 2020
View reviewed changes
Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++
Confirmed that NTP works well on my local. 👍

@NejcZdovc NejcZdovc added the CI/skip-ios Do not run CI builds for iOS label Mar 26, 2020
@NejcZdovc NejcZdovc merged commit db1ecd8 into master Mar 26, 2020
@NejcZdovc NejcZdovc deleted the ntp-blank branch March 26, 2020 10:00
brave-builds pushed a commit that referenced this pull request Mar 31, 2020
@brave-browser-releases
Uplift of #5066 (squashed) to beta
1b6f6fd
@brave-builds brave-builds mentioned this pull request Mar 31, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanml ryanml ryanml approved these changes

@simonhong simonhong simonhong approved these changes

@bsclifton bsclifton Awaiting requested review from bsclifton

Assignees

@NejcZdovc NejcZdovc

Labels
CI/skip-ios Do not run CI builds for iOS feature/newtab
Projects
None yet
Milestone
1.8.x - Release
Development

Successfully merging this pull request may close these issues.

Empty new tab page
3 participants
@NejcZdovc @simonhong @ryanml