Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade patches from Chromium 80.0.3987.149 to Chromium 80.0.3987.162 #5130

Merged
merged 1 commit into from
Apr 1, 2020

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Apr 1, 2020

Fixes brave/brave-browser#8947
Related brave/brave-browser#8957

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@bsclifton bsclifton added this to the 1.5.x - Release Hotfix 3 milestone Apr 1, 2020
@bsclifton bsclifton requested a review from mkarolin April 1, 2020 06:04
@bsclifton bsclifton requested a review from bridiver as a code owner April 1, 2020 06:04
@bsclifton bsclifton self-assigned this Apr 1, 2020
@mkarolin mkarolin added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux labels Apr 1, 2020
@mkarolin
Copy link
Collaborator

mkarolin commented Apr 1, 2020

CI failed on MacOS with

03:19:01  ../../brave/browser/brave_browser_process_impl.h:14:10: fatal error: 'brave/components/brave_referrals/buildflags/buildflags.h' file not found
03:19:01  #include "brave/components/brave_referrals/buildflags/buildflags.h"
03:19:01           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
03:19:01  1 error generated.

Will rerun.

Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit 3cf8e15 into 1.5.x-desktop Apr 1, 2020
@bsclifton bsclifton deleted the 80.0.3987.162_1.5.x-desktop_30 branch April 1, 2020 18:23
bsclifton added a commit that referenced this pull request Apr 3, 2020
Upgrade patches from Chromium 80.0.3987.149 to Chromium 80.0.3987.162
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants