Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mac crash reporting (uplift to 1.7.x) #5138

Merged
merged 5 commits into from
Apr 2, 2020
Merged

Fix mac crash reporting (uplift to 1.7.x) #5138

merged 5 commits into from
Apr 2, 2020

Conversation

mbacchi
Copy link
Contributor

@mbacchi mbacchi commented Apr 1, 2020 •
edited by bsclifton
Loading

Uplift of #5064 and #5082 to 1.7.x
Related brave/brave-browser#8970

Fixes brave/brave-browser#8864
Fixes brave/brave-browser#8896

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

bridiver and others added 5 commits April 1, 2020 11:48
@bridiver @mbacchi
don't duplicate chrome_app
bb3a84f
@bridiver @mbacchi
restore KSChannelID for crash reporting channel
06c3a44
@bridiver @mbacchi
update crash reporting url
14d9a6e
@bridiver @mbacchi
lint
4df5cb3
@mbacchi
Uplift part of the change manually for PR 5082
025f8d9 
I updated the patches/chrome-BUILD.gn.patch file
in an earlier cherry pick operation, but am adding
this change manually now.

#5082
@mbacchi mbacchi added CI/skip-android Do not run CI builds for Android CI/skip-linux CI/skip-ios Do not run CI builds for iOS labels Apr 1, 2020
@mbacchi mbacchi self-assigned this Apr 1, 2020
@mbacchi mbacchi requested a review from kjozwiak April 1, 2020 21:34
@mbacchi
Copy link
Contributor Author

mbacchi commented Apr 1, 2020

The manual build I ran completed successfully with these patches. Info.plist looks accurate.

@mbacchi mbacchi mentioned this pull request Apr 2, 2020
Merged
29 tasks
@bsclifton bsclifton changed the title Fix mac crash reporting 1.7.x Fix mac crash reporting (uplift to 1.7.x) Apr 2, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Apr 2, 2020

QA went through the original PR on Nightly as per #5064 (comment) 👍

kjozwiak
kjozwiak approved these changes Apr 2, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.7.x approved after deliberating with @brave/uplift-approvers. Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit 3ad83bf into 1.7.x Apr 2, 2020
@kjozwiak kjozwiak deleted the fix-mac-crash-reporting-1.7.x branch April 2, 2020 21:47
@kjozwiak kjozwiak added this to the 1.7.x - Release milestone Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@bridiver bridiver bridiver approved these changes

@bsclifton bsclifton Awaiting requested review from bsclifton

@simonhong simonhong Awaiting requested review from simonhong

@mkarolin mkarolin Awaiting requested review from mkarolin

Assignees

@mbacchi mbacchi

Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS
Projects
None yet
Milestone
1.7.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@mbacchi @kjozwiak @bridiver