Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds processor to transactions #5210

Merged
merged 1 commit into from
Apr 10, 2020
Merged

Adds processor to transactions #5210

merged 1 commit into from
Apr 10, 2020

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Apr 9, 2020

Resolves brave/brave-browser#8986

Submitter Checklist:

Test Plan:

  • enable rewards
  • claim grant
  • connect to KYC uphold
  • set AC amount to be more than claimed grant
  • add verified publisher to AC table
  • wait for AC to trigger
  • go to monthly report and make sure that in transaction you see source in parenthesis

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc self-assigned this Apr 9, 2020
@NejcZdovc NejcZdovc force-pushed the processor branch 2 times, most recently from a986884 to 6374027 Compare April 9, 2020 18:23
@NejcZdovc NejcZdovc marked this pull request as ready for review April 9, 2020 19:45
@NejcZdovc NejcZdovc requested a review from gdregalo as a code owner April 9, 2020 19:45
@NejcZdovc NejcZdovc added this to the 1.9.x - Nightly milestone Apr 9, 2020
@NejcZdovc NejcZdovc requested a review from a team April 9, 2020 19:46
@NejcZdovc NejcZdovc added the CI/skip-ios Do not run CI builds for iOS label Apr 10, 2020
@NejcZdovc
Copy link
Contributor Author

CI not related to this PR

@NejcZdovc NejcZdovc merged commit e7561c0 into master Apr 10, 2020
@NejcZdovc NejcZdovc deleted the processor branch April 10, 2020 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS feature/rewards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add source to monthly statement
2 participants