Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iOS serveSampleAd unit tests for Brave Ads #5228

Merged
merged 1 commit into from
Apr 12, 2020
Merged

Fix iOS serveSampleAd unit tests for Brave Ads #5228

merged 1 commit into from
Apr 12, 2020

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Apr 12, 2020

Resolves brave/brave-browser#9149

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@tmancey tmancey added this to the 1.9.x - Nightly milestone Apr 12, 2020
@tmancey tmancey requested a review from kylehickinson April 12, 2020 00:32
@tmancey tmancey self-assigned this Apr 12, 2020
@tmancey tmancey merged commit 1b2ed33 into master Apr 12, 2020
@tmancey tmancey deleted the issues/9149 branch April 12, 2020 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix iOS serveSampleAd unit tests for Brave Ads
2 participants