-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement NTP Custom homepage ("super referral") (uplift to 1.8.x) #5296
Implement NTP Custom homepage ("super referral") (uplift to 1.8.x) #5296
Conversation
…ponent Rename ntp_sponsored_images module to ntp_background_images
86d6d99
to
97ca94d
Compare
I think there is an Android error here, possibly due to merge conflict resolution that I did: Will check this out |
android/java/org/chromium/chrome/browser/ntp_background_images/NTPBackgroundImagesBridge.java
Outdated
Show resolved
Hide resolved
Linux had an issue too:
|
Implement NTP Custom homepage ("super referral")
97ca94d
to
2685a5c
Compare
CI looks good! There was one browser test failure on macOS:
This is a known intermittent issue captured with brave/brave-browser#9339 Ready for uplift consideration 😄 |
QA verified the PRs on Nightly as per #4866 (comment) and #5290 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uplift into 1.8.x
approved after deliberating with @brave/uplift-approvers. Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.
Uplift of #4975
Uplift of #4866
Uplift of #5290
Fixes brave/brave-browser#8540
Fixes brave/brave-browser#8218
Fixes brave/brave-browser#9329
Approved, please ensure that before merging:
After you merge: