Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix for si centerpoint 1.8.x (Uplift to 1.8.x) #5359

Merged
merged 1 commit into from
Apr 26, 2020

Conversation

deeppandya
Copy link
Contributor

Uplift of #5349

@deeppandya deeppandya added the CI/skip-ios Do not run CI builds for iOS label Apr 24, 2020
@deeppandya deeppandya self-assigned this Apr 24, 2020
@kjozwiak
Copy link
Member

Restarting Android as dist failed as per https://ci.brave.com/job/brave-browser-build-pr/job/hotfix_for_SI_centerpoint_1.8.x/1/execution/node/360/log/. Looks like the spot instance was disconnected:

12:05:17  Cannot contact i-00871e219322d539c: hudson.remoting.ChannelClosedException: Channel "hudson.remoting.Channel@44cd35b8:i-00871e219322d539c": Remote call on i-00871e219322d539c failed. The channel is closing down or has closed down
12:10:20  Could not connect to i-00871e219322d539c to send interrupt signal to process

Looks like xUnit failed to publish on macOS for both test-unit and test-browser. However, this is a known intermittent issue and doesn't block uplift.

@kjozwiak kjozwiak added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Apr 24, 2020
@kjozwiak kjozwiak added this to the 1.8.x - Release milestone Apr 24, 2020
@kjozwiak
Copy link
Member

QA verified #5349 on Nightly as per #5349 (comment).

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.8.x approved after deliberating with @brave/uplift-approvers. Please make sure that all the correct labels are being used and the associated issue is moved into the correct milsetone.

@kjozwiak kjozwiak merged commit 51b6425 into 1.8.x Apr 26, 2020
@kjozwiak kjozwiak deleted the hotfix_for_SI_centerpoint_1.8.x branch April 26, 2020 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants