Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manual uplift of PR 5039 to 1.8.x #5364

Closed
wants to merge 1 commit into from
Closed

Manual uplift of PR 5039 to 1.8.x #5364

wants to merge 1 commit into from

Conversation

gdregalo
Copy link
Contributor

@gdregalo gdregalo commented Apr 24, 2020 •
edited by bsclifton
Loading

Uplift of #5039
Fixes brave/brave-browser#8511
Implement User wallets (Uphold) on Android

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@gdregalo gdregalo added this to the 1.8.x - Release milestone Apr 24, 2020
@gdregalo gdregalo requested a review from a team April 24, 2020 19:14
@kjozwiak kjozwiak removed the request for review from a team May 4, 2020 15:45
@kjozwiak kjozwiak removed this from the 1.8.x - Release milestone May 4, 2020
@kjozwiak kjozwiak closed this May 4, 2020
@kjozwiak
Copy link
Member

kjozwiak commented May 4, 2020

As discussed earlier with @SergeyZhukovsky @mandar-brave, this will be landing in 1.9.x via #5367 and won't be part of 1.8.x. Closing issue.

@bsclifton bsclifton deleted the uplift-android-uphold-1.8.x branch November 10, 2023 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gdregalo gdregalo

Labels
feature/rewards
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gdregalo @kjozwiak