Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement canvas blocking v2 #5541

Merged
merged 1 commit into from
May 29, 2020
Merged

Implement canvas blocking v2 #5541

merged 1 commit into from
May 29, 2020

Conversation

pilgrim-brave
Copy link
Contributor

@pilgrim-brave pilgrim-brave commented May 13, 2020 •
edited
Loading

Resolves brave/brave-browser#10045

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@pilgrim-brave pilgrim-brave requested a review from bridiver as a code owner May 13, 2020 16:32
@pilgrim-brave pilgrim-brave self-assigned this May 13, 2020
@pilgrim-brave pilgrim-brave added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels May 14, 2020
@pilgrim-brave pilgrim-brave removed CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels May 27, 2020
@pilgrim-brave pilgrim-brave force-pushed the mpilgrim_canvas_blocking_v2 branch from 80e54a8 to 97262ce Compare May 28, 2020 14:49
@pilgrim-brave pilgrim-brave force-pushed the mpilgrim_canvas_blocking_v2 branch 3 times, most recently from 3d5a06a to f70404f Compare May 28, 2020 21:27
@pilgrim-brave pilgrim-brave force-pushed the mpilgrim_canvas_blocking_v2 branch 3 times, most recently from 0edd9ba to c075c12 Compare May 29, 2020 12:27
@pilgrim-brave
Implement canvas blocking v2
8bad4af 
tests

refactor

refactor

fix logic

header guard
@pilgrim-brave pilgrim-brave force-pushed the mpilgrim_canvas_blocking_v2 branch from c075c12 to 8bad4af Compare May 29, 2020 14:11
@pilgrim-brave pilgrim-brave merged commit c78c1ca into master May 29, 2020
@pilgrim-brave pilgrim-brave deleted the mpilgrim_canvas_blocking_v2 branch May 29, 2020 16:46
@bbondy bbondy added this to the 1.11.x - Beta milestone Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bridiver bridiver bridiver approved these changes

Assignees

@pilgrim-brave pilgrim-brave

Labels
None yet
Projects
None yet
Milestone
1.11.x - Release #1
Development

Successfully merging this pull request may close these issues.

Fingerprinting 2.0: Canvas content querying
3 participants
@pilgrim-brave @bridiver @bbondy