Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redeem id can be empty #5670

Merged
merged 1 commit into from
May 28, 2020
Merged

Redeem id can be empty #5670

merged 1 commit into from
May 28, 2020

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented May 27, 2020

Resolves brave/brave-browser#9967

Submitter Checklist:

Test Plan:

  • defined in the issue

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc added feature/rewards CI/skip-ios Do not run CI builds for iOS labels May 27, 2020
@NejcZdovc NejcZdovc added this to the 1.11.x - Nightly milestone May 27, 2020
@NejcZdovc NejcZdovc requested a review from a team May 27, 2020 13:24
@NejcZdovc NejcZdovc self-assigned this May 27, 2020
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NejcZdovc NejcZdovc added CI/skip-android Do not run CI builds for Android CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels May 27, 2020
@NejcZdovc
Copy link
Contributor Author

CI was aborted for windows, restarting

@NejcZdovc NejcZdovc merged commit 8fec9f5 into master May 28, 2020
@NejcZdovc NejcZdovc deleted the fix-claim-flow branch May 28, 2020 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 feature/rewards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tokens transferred to uphold not marked as redeemed in DB
3 participants