Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes sku contribution flow for unblinded tokens (uplift to 1.10.x) #5682

Merged
merged 1 commit into from
Jun 1, 2020
Merged

Fixes sku contribution flow for unblinded tokens (uplift to 1.10.x) #5682

merged 1 commit into from
Jun 1, 2020

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented May 28, 2020 •
edited by NejcZdovc
Loading

Uplift of #5671
Resolves brave/brave-browser#9962

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from NejcZdovc as a code owner May 28, 2020 06:24
@brave-builds brave-builds requested a review from a team May 28, 2020 06:24
@brave-builds brave-builds self-assigned this May 28, 2020
@brave-builds brave-builds added this to the 1.10.x - Beta milestone May 28, 2020
@NejcZdovc NejcZdovc removed their request for review May 28, 2020 06:25
LaurenWags
LaurenWags approved these changes Jun 1, 2020
View reviewed changes
Copy link
Member

@LaurenWags LaurenWags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NejcZdovc uplift into 1.10.x approved after deliberating with @brave/uplift-approvers. Please make sure that all the correct labels are being used and the associated issues are moved into the correct milestone.

@NejcZdovc NejcZdovc merged commit 90f326c into 1.10.x Jun 1, 2020
@NejcZdovc NejcZdovc deleted the pr5671_sku-tokens-contribution_1.10.x branch June 1, 2020 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaurenWags LaurenWags LaurenWags approved these changes

Assignees

@brave-builds brave-builds

Labels
feature/rewards
Projects
None yet
Milestone
1.10.x - Release
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @LaurenWags @NejcZdovc @brave-browser-releases