Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add contributions back into brave://rewards-internals page #5739

Merged
merged 1 commit into from
Jun 5, 2020
Merged

Add contributions back into brave://rewards-internals page #5739

merged 1 commit into from
Jun 5, 2020

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Jun 4, 2020 •
edited
Loading

Resolves brave/brave-browser#8633

Submitter Checklist:

Test Plan:

  • Enable Rewards
  • Claim grant
  • Make a few contributions
  • Load brave://rewards-internals
  • Visit the "Contributions" tab and verify that contribution/publisher info looks correct

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@emerick emerick requested review from NejcZdovc and tmancey as code owners June 4, 2020 15:20
@emerick emerick self-assigned this Jun 4, 2020
@emerick emerick requested a review from zenparsing June 4, 2020 15:20
zenparsing
zenparsing reviewed Jun 4, 2020
View reviewed changes
components/brave_rewards/resources/internals/components/contributions.tsx Show resolved Hide resolved
components/brave_rewards/resources/internals/components/contributionPublisher.tsx Outdated Show resolved Hide resolved
components/brave_rewards/resources/internals/components/contributionPublisher.tsx Outdated Show resolved Hide resolved
components/brave_rewards/resources/internals/components/contribution.tsx Outdated Show resolved Hide resolved
components/brave_rewards/browser/rewards_service_impl.cc Outdated Show resolved Hide resolved
components/brave_rewards/browser/contribution_publisher.cc Show resolved Hide resolved
components/brave_rewards/browser/contribution_info.cc Outdated Show resolved Hide resolved
components/brave_rewards/browser/rewards_service_impl.cc Show resolved Hide resolved
browser/ui/webui/brave_rewards_internals_ui.cc Outdated Show resolved Hide resolved
@emerick emerick force-pushed the rewards-internals-contributions branch 2 times, most recently from a572dda to 22581f6 Compare June 4, 2020 18:48
@emerick emerick force-pushed the rewards-internals-contributions branch from 22581f6 to d9a7f8d Compare June 4, 2020 19:47
@emerick emerick requested review from zenparsing and NejcZdovc June 4, 2020 19:49
@NejcZdovc
Copy link
Contributor

CI all good, it only failed on test-install

@emerick emerick force-pushed the rewards-internals-contributions branch from d9a7f8d to 31bce0b Compare June 5, 2020 12:34
@emerick emerick force-pushed the rewards-internals-contributions branch from 31bce0b to 840920f Compare June 5, 2020 12:35
@emerick emerick requested a review from NejcZdovc June 5, 2020 14:11
tmancey
tmancey approved these changes Jun 5, 2020
View reviewed changes
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

@emerick
Copy link
Contributor Author

emerick commented Jun 5, 2020

CI test-install failed on an unrelated problem, so will merge now.

@emerick emerick merged commit ce03732 into master Jun 5, 2020
@emerick emerick deleted the rewards-internals-contributions branch June 5, 2020 15:11
@NejcZdovc NejcZdovc added this to the 1.12.x - Nightly milestone Jun 5, 2020
brave-builds pushed a commit that referenced this pull request Jun 10, 2020
@brave-browser-releases
Uplift of #5739 (squashed) to beta
26507f2
@brave-builds brave-builds mentioned this pull request Jun 10, 2020
Merged
4 tasks
@LaurenWags
Copy link
Member

Verified passed with

Brave 1.12.28 Chromium: 83.0.4103.106 (Official Build) nightly (64-bit)
Revision ce7134bb3d95141cd18f1e65772a4247f282d950-refs/branch-heads/4103@{#694}
OS macOS Version 10.14.6 (Build 18G3020)
  • Verified test plan from description

Screen Shot 2020-06-16 at 11 55 43 AM

@GeetaSarvadnya GeetaSarvadnya mentioned this pull request Jun 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NejcZdovc NejcZdovc NejcZdovc approved these changes

@zenparsing zenparsing zenparsing approved these changes

@tmancey tmancey tmancey approved these changes

Assignees

@emerick emerick

Labels
feature/rewards
Projects
None yet
Milestone
1.12.x - Release #1
Development

Successfully merging this pull request may close these issues.

[Desktop] Add Contributions history to brave://rewards-internals/
5 participants
@emerick @NejcZdovc @LaurenWags @tmancey @zenparsing