Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for auto contribution contribution #578

Merged
merged 4 commits into from
Oct 10, 2018
Merged

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Oct 8, 2018

Fixes brave/brave-browser#918

Ledger implementation brave-intl/bat-native-ledger#108

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  • enable rewards
  • add site
  • claim grant
  • close browser
  • modify go to your profile (Default/ledger_state) and modify reconcileStamp to now+5min)
  • start browser
  • visit some sites
  • wait for contribution to finish

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@NejcZdovc NejcZdovc self-assigned this Oct 8, 2018
@NejcZdovc NejcZdovc force-pushed the contribution branch 2 times, most recently from 9a249a0 to 5a860eb Compare October 8, 2018 14:23
@NejcZdovc NejcZdovc changed the title Adds support for auto contributions Adds support for auto contribution contribution Oct 8, 2018
@NejcZdovc NejcZdovc changed the base branch from master to reports-probi October 9, 2018 08:58
@NejcZdovc NejcZdovc changed the base branch from reports-probi to master October 10, 2018 19:00
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@NejcZdovc NejcZdovc merged commit 29406b6 into master Oct 10, 2018
@NejcZdovc NejcZdovc deleted the contribution branch October 10, 2018 20:01
NejcZdovc added a commit that referenced this pull request Oct 10, 2018
Adds support for auto contribution contribution
@NejcZdovc
Copy link
Contributor Author

NejcZdovc commented Oct 10, 2018

master 29406b6
0.56 f11834b
0.55 a2837af

NejcZdovc added a commit that referenced this pull request Oct 10, 2018
Adds support for auto contribution contribution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contribution process
3 participants