Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes ad conversions fail after a creative has expired - 1.11.x #5837

Merged
merged 1 commit into from
Jun 30, 2020
Merged

Fixes ad conversions fail after a creative has expired - 1.11.x #5837

merged 1 commit into from
Jun 30, 2020

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Jun 14, 2020 •
edited by kjozwiak
Loading

Uplift of #5834
Resolves brave/brave-browser#10240

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@tmancey tmancey added this to the 1.11.x - Beta milestone Jun 14, 2020
@tmancey tmancey requested a review from a team June 14, 2020 08:14
@tmancey tmancey self-assigned this Jun 14, 2020
@tmancey tmancey force-pushed the issues/10240-1.11.x branch from d3fcbbc to 114542d Compare June 17, 2020 07:15
@tmancey tmancey changed the title Fixes ad conversions fail after a creative has expired Fixes ad conversions fail after a creative has expired - 1.11.x Jun 17, 2020
kjozwiak
kjozwiak approved these changes Jun 30, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.11.x approved after deliberating with @brave/uplift-approvers. QA has also verified the PR on Nightly as per #5834 (comment).

@kjozwiak kjozwiak merged commit 9dc36a7 into 1.11.x Jun 30, 2020
@kjozwiak kjozwiak deleted the issues/10240-1.11.x branch June 30, 2020 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@tmancey tmancey

Labels
bug feature/ads
Projects
None yet
Milestone
1.11.x - Release #1
Development

Successfully merging this pull request may close these issues.
2 participants
@tmancey @kjozwiak