Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds script for YT on Android to block ads (uplift to 1.11.x) #5868

Merged
merged 1 commit into from
Jun 18, 2020
Merged

adds script for YT on Android to block ads (uplift to 1.11.x) #5868

merged 1 commit into from
Jun 18, 2020

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Jun 16, 2020 •
edited by kjozwiak
Loading

Uplift of #5860
Resolves brave/brave-browser#10241

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team June 16, 2020 20:20
@brave-builds brave-builds self-assigned this Jun 16, 2020
@brave-builds brave-builds added this to the 1.11.x - Beta milestone Jun 16, 2020
@SergeyZhukovsky SergeyZhukovsky added CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Jun 16, 2020
kjozwiak
kjozwiak approved these changes Jun 18, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.11.x approved after deliberating with @brave/uplift-approvers. QA has also verified the PR on Nightly as per #5860 (comment). However, we've never been able to reproduce the original issue so we'll most likely need to wait till this is released to see if it resolved the issue some users were experiencing.

@kjozwiak kjozwiak merged commit 73911a8 into 1.11.x Jun 18, 2020
@kjozwiak kjozwiak deleted the pr5860_android_yt_adblock_1.11.x branch June 18, 2020 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
1.11.x - Release #1
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @kjozwiak @SergeyZhukovsky @brave-browser-releases