Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NewTabPageView to fix the issue with empty tiles (Uplift 1.11.x) #5885

Merged
merged 1 commit into from
Jun 18, 2020
Merged

Update NewTabPageView to fix the issue with empty tiles (Uplift 1.11.x) #5885

merged 1 commit into from
Jun 18, 2020

Conversation

deeppandya
Copy link
Contributor

@deeppandya deeppandya commented Jun 17, 2020 •
edited by kjozwiak
Loading

Uplift of #5882

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@deeppandya deeppandya added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Jun 17, 2020
@deeppandya deeppandya added this to the 1.11.x - Beta milestone Jun 17, 2020
@deeppandya deeppandya requested a review from a team June 17, 2020 20:52
@deeppandya deeppandya self-assigned this Jun 17, 2020
kjozwiak
kjozwiak approved these changes Jun 18, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.11.x approved after deliberating with @brave/uplift-approvers.

@kjozwiak kjozwiak merged commit a8a122c into 1.11.x Jun 18, 2020
@kjozwiak kjozwiak deleted the empty_ntp_fix_dp_1_11_x branch June 18, 2020 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@deeppandya deeppandya

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
1.11.x - Release #1
Development

Successfully merging this pull request may close these issues.
2 participants
@deeppandya @kjozwiak