-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add backup notice #5958
Add backup notice #5958
Conversation
67c4fa4
to
ddb1865
Compare
@emerick can we please move text for new users into backup tab, so that we are not stacking dialogs and we are just switching content based on user balance |
1d42470
to
70e3159
Compare
a021961
to
ba2b72e
Compare
vendor/bat-native-ledger/src/bat/ledger/internal/wallet/create.cc
Outdated
Show resolved
Hide resolved
@NejcZdovc Updated with browser tests but there's one small outstanding issue, see my comment above. |
e266ec5
to
5b481bd
Compare
CI had a browser test failure on linux, restarting there. Ignoring test-install failure on Mac. |
All CI is green now except for previously-noted test-install failure on Mac. |
Resolves brave/brave-browser#10021
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
OnFetch
callbackOnFetch
callbackReviewer Checklist:
After-merge Checklist:
changes has landed on.