Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes movement inside the more cards NTP settings section when interacting #6097

Merged
merged 1 commit into from
Jul 17, 2020

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Jul 16, 2020

Fixes brave/brave-browser#10757

The actual SVG's differed in outer bound width slightly, so just defining height/width constraints for container fixes that.

This will also prevent long translated strings from causing the same issue.

Submitter Checklist:

Test Plan:

Defined in issue

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@ryanml ryanml requested review from petemill and emerick July 16, 2020 05:24
@ryanml ryanml requested a review from bridiver as a code owner July 16, 2020 05:24
@ryanml ryanml self-assigned this Jul 16, 2020
@ryanml ryanml force-pushed the fix-10757 branch 2 times, most recently from 0e3bbf3 to 3f296d4 Compare July 16, 2020 06:00
@ryanml ryanml removed the request for review from bridiver July 16, 2020 06:07
Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as design is ok cutting the text off when the translation is too long for 1 line

Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryanml
Copy link
Contributor Author

ryanml commented Jul 17, 2020

Failures unrelated

@ryanml ryanml merged commit e9e71a7 into master Jul 17, 2020
@ryanml ryanml deleted the fix-10757 branch July 17, 2020 06:28
@ryanml ryanml added this to the 1.13.x - Nightly milestone Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Desktop] Brave Rewards in add widget menu jumps around when other widgets are shown/hidden
3 participants